-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CloudWatch SDK #1151
feat: CloudWatch SDK #1151
Conversation
Amend docs description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Just a few remarks and you missed the dependency and reference from the docs/pom.xml (see
quarkus-amazon-services/docs/pom.xml
Line 129 in 65f5cff
<include>quarkus-amazon-cognitouserpools.adoc</include> |
pages in the included directory must be copied automatically by maven at the end of the build
Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com>
Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com>
Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com>
Thanks for the review, I will adjust these tomorrow and do the same for #1154 |
Could you add a small integration test based on the quickstart to assert it works with LocalStack. |
Sure, let me do something by Monday |
...loyment/src/test/java/io/quarkus/amazon/cloudwatch/deployment/CloudWatchAsyncClientTest.java
Outdated
Show resolved
Hide resolved
@all-contributors please add @andrezimmermann for code |
I've put up a pull request to add @andrezimmermann! 🎉 |
I've added the CloudWatch SDK, based of the SSM SDK scaffolding.
Over the documentation I just pretended that there is the cloudwatch quickstart and coded an HelloWorld example.
Work for #1150
On another note, I realized while coding the example that I actually wanted the CloudWatchLogs SDK, will be working on it if this PR is passable