Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dev service with testcontainer #69

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

MartinWitt
Copy link
Contributor

@MartinWitt MartinWitt commented Aug 12, 2023

Given I am neither a quarkus nor couchbase expert, this is a first implementation.

@programmatix
Copy link
Contributor

Thanks @MartinWitt . I'm currently in the process of trying to get the Quarkus Couchbase extension compiling natively again, and will take a look at that change after that.

Copy link
Contributor

@programmatix programmatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still trying to get native compilation working. But I don't want to block this change indefinitely, and we are at a very early stage of development still. So approving - and thank you for the patch.

@programmatix programmatix merged commit a795d78 into quarkiverse:main Oct 23, 2023
@MartinWitt
Copy link
Contributor Author

It looks like the CI is red because the branch was stale, and you added a formatter. I will push a PR for a green master soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants