Change tests assesrtions to pass on FIPS environment #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| response.statusCode(500) | ||
| .body(containsString("java.security.NoSuchAlgorithmException: Cannot find any provider supporting")); | ||
|
|
||
| final List<String> messages = PolicyTestUtils.drainMessages("drainMessages", 2); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
|
@ppalaga (@ffang ) Here is a few lines from the log when executing CustomEncryptSignPolicyIT.helloCustomizedValuesCorrectly JVM part of log, FIPS (looks as expected): native part of the log: You can see the same line in both logs Do you have an idea, what can be wrong? I'm pasting whole log here |
|
I'm able to debug the JVM execution via remote and I see the value entering |
|
Thanks @ppalaga for the help! |
JiriOndrusek
force-pushed
the
fips-module-04
branch
from
7a2eae3
to
ae8684d
Compare
|
I fixed the problems and change is prepared to be merged. If test runs in native and the machine environment (where the test runs) or the binary is FIPS enabled, the test fails with the message: In jvm, test detects, whether system is FIPS compliant, and test asserts success or failure based on this information. To show behavior correctly: In non-fips mode (jvm or native), results are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1285
replaces #1286
Tests are capable of knowing whether the environment is FIPS, therefore assertions are changed accordingly (whether success or failure is expected)
!There is a problem with the execution in the native in the FIPS!
non-FIPS - jvm and native works
FIPS - jvm works, native fails - I'm investigating it now.
I created this draft to see the CI results.