Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injecting non-default datasource for PgVector store #110

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jmartisk
Copy link
Collaborator

@jmartisk jmartisk commented Dec 8, 2023

@jmartisk jmartisk requested a review from a team as a code owner December 8, 2023 08:45
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@geoand geoand changed the title Allow injecting non-default datasource for PgVector store, produce an… Allow injecting non-default datasource for PgVector store Dec 8, 2023
@geoand
Copy link
Collaborator

geoand commented Dec 8, 2023

We probably want something like this for Redis too

@jmartisk
Copy link
Collaborator Author

jmartisk commented Dec 8, 2023

Redis "supports" it but it's broken I think, we don't declare the injection points properly. I'll fix it today too.

@jmartisk jmartisk merged commit 829ee63 into quarkiverse:main Dec 8, 2023
0 of 2 checks passed
@jmartisk jmartisk deleted the pgvector-ds-choice branch December 8, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PgVector processor needs to produce EmbeddingStoreBuildItem (or find a completely different approach)
2 participants