-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first version of IBM BAM support #222
Conversation
373a81e
to
fbd44e1
Compare
Hi @geoand , I'm looking at the code that you are writing to implement the This could be a problem because the API endpoint that you are calling in the WatsonxChatModel.java class, the The correct url to call should be This is what I understood by reading some of the online documentation and trying the free version of the watsonx product. |
Another two differences are:
Maybe using the BAM APIs as a starting point is not so good because from my understanding there are differences that don't allow your code to be used for both products. |
I guess we need to rename in into bam instead of watsonx. |
If your idea is to integrate the BAM APIs into the |
Thanks for the input @andreadimaio! So maybe we should just keep this as for us to be able to experiment with BAM is and not merge it? |
I would just rename it and keep it there. We are likely going to use this
for demo purposes.
…On Mon 15 Jan 2024 at 07:40, Georgios Andrianakis ***@***.***> wrote:
Thanks for the input @andreadimaio <https://github.com/andreadimaio>!
So maybe we should just keep this as for us to be able to experiment with
BAM is and not merge it?
—
Reply to this email directly, view it on GitHub
<#222 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCG7IPPI3CJHS3VRPE7ILYOTFORAVCNFSM6AAAAABBYKKD76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGM4TGNBYGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
PR updated to replace all occurences of |
No description provided.