Introduce the ability to use inject models #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cescoffier @maxandersen @dandreadis @edeandrea @andreadimaio @sarxos who have all mentioned something similar. |
|
@cescoffier can you have a look at this when you get some time, as I would like to get a new release out including this? Thanks! |
cescoffier
requested changes
Feb 2, 2024
...tests/openai/src/main/java/org/acme/example/openai/chat/QuarkusOpenAiClientChatResource.java
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkiverse/langchain4j/ModelName.java
Outdated
Show resolved
Hide resolved
| @RegisterAiService( | ||
| chatLanguageModelSupplier = MyChatModelSupplier.class | ||
| ) | ||
| @RegisterAiService(modelName="m1") |
There was a problem hiding this comment.
Now that we have the qualifier, should it be used there instead of a parameter? Or allow both?
There was a problem hiding this comment.
I don't really like having multiple unless we really have to
cescoffier
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now allows models to be named and usable via CDI with the
@ModelNamequalifier.Furthermore,
@RegisterAiServicenow has themodelNameattribute that can be used to select which model should be used for that service in question.Relates to: #246, #237, #210, #42, #41, #10