-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neo4j embedding store #548
Conversation
CC @adriens if you want to give it a look already. You can set Update: Now after updating to quarkus-neo4j 4.0.0 everything should work just fine |
neo4j/deployment/src/test/java/io/quarkiverse/langchain4j/neo4j/Neo4jEmbeddingStoreTest.java
Outdated
Show resolved
Hide resolved
@Override | ||
public Neo4jEmbeddingStore apply(SyntheticCreationalContext<Neo4jEmbeddingStore> context) { | ||
Neo4jEmbeddingStore.Neo4jEmbeddingStoreBuilder builder = Neo4jEmbeddingStore.builder(); | ||
Driver driver = context.getInjectedReference(Driver.class, new Default.Literal()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not know that trick, good stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to use the static instance of the qualifier instead of creating a new one
cb0dee1
to
610ff76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple small comments
neo4j/runtime/src/main/java/io/quarkiverse/langchain4j/neo4j/runtime/Neo4jRuntimeConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Simons <michael@simons.ac>
No description provided.