Reuse embeddings #666
Merged
Reuse embeddings #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Jun 11, 2024
...sy-rag/runtime/src/main/java/io/quarkiverse/langchain4j/easyrag/runtime/EasyRagRecorder.java
Outdated
Show resolved
Hide resolved
edeandrea
commented
Jun 11, 2024
edeandrea
commented
Jun 11, 2024
edeandrea
force-pushed
the
reuse-embeddings
branch
4 times, most recently
from
f3106a1
to
9895297
Compare
jmartisk
reviewed
Jun 12, 2024
...sy-rag/runtime/src/main/java/io/quarkiverse/langchain4j/easyrag/runtime/EasyRagRecorder.java
Show resolved
Hide resolved
|
Added just one minor comment, otherwise, this is great! |
edeandrea
force-pushed
the
reuse-embeddings
branch
from
f174c96
to
82f6d29
Compare
jmartisk
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse embeddings
Closes #663