Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the email me a poem sample #678

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Update the email me a poem sample #678

merged 2 commits into from
Jun 17, 2024

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Jun 14, 2024 •
edited

The following changes have been made:

  • Use quarkus-mailpit
    • This is done to make the setup simpler
  • Introduce the LGTM observability Dev Service
    • This is done so users don't have to start anything manually
    • For this to work, users need to use -Dobservability
  • Use gpt-4o
    • This is done because GTP-3.x can sometimes result in multiple tool invocations
    • Improve the prompt to ensure that no markers are added
  • Update README accordingly

@geoand geoand requested a review from a team as a code owner June 14, 2024 09:33
@geoand geoand changed the title Update the email me a poem sample: Update the email me a poem sample Jun 14, 2024
@jmartisk
Copy link
Collaborator

IMO the mail server component is quite important for demoing (I've shown this at several conferences now)...
"sending an email" by just printing something in the log? :( not happy about that TBH

@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024 •
edited

What I really don't like is that unless I actually do a prerequisite step, the sample doesn't work - I really want demoers to have not to do anything but start the application to get the basic functionality working

@jmartisk
Copy link
Collaborator

jmartisk commented Jun 17, 2024 •
edited

Could we then switch to https://github.com/quarkiverse/quarkus-mailpit? I haven't tried that, but it claims it can run an SMTP server as a dev service, and the emails can be viewed in the Dev UI, that actually sounds cool

@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024

Oh, that's nice!

Let me try it and see how it goes

maxandersen
maxandersen reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes Overall but should we make the telemetry optional as it's quite heavy to fetch and it's optional for showing the main funktionality of tools calling. ?

@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024

We can do that

@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024

@jmartisk the Mailpit extension is amazing, I'm adding it

@maxandersen
Copy link
Member

Could we then switch to https://github.com/quarkiverse/quarkus-mailpit? I haven't tried that, but it claims it can run an SMTP server as a dev service, and the emails can be viewed in the Dev UI, that actually sounds cool

+1 for mailpit. I'm actually wondering if we shouldn't simply make the devservice that comes by default with mailer. But that's a separate issue.

@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024

Yeah, mailpit could be a very nice default

@geoand
Update the email me a poem sample:
f93eccd 
* Use quarkus-mailpit
   - This is done to make the setup simpler
* Introduce the LGTM observability Dev Service
   - This is done so users don't have to start anything manually
   - For this to work, users need to use -Dobservability
* Use gpt-4o
   - This is done because GTP-3.x can sometimes result in multiple tool invocations
   - Improve the prompt to ensure that no markers are added
* Update README accordingly
@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024

PR updated

@geoand
Copy link
Collaborator Author

geoand commented Jun 17, 2024

@jmartisk I temporarily disabled ChromaEmbeddingStoreCDITest

@jmartisk
Copy link
Collaborator

Yeah I'm looking at it but I'm puzzled, because it just started failing independently of any changes in our codebase (and the Chroma image version didn't get updated either)

@geoand geoand merged commit e39fa04 into main Jun 17, 2024
12 checks passed
@geoand geoand deleted the email-sample branch June 17, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geoand @jmartisk @maxandersen