Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: Allow RAG and tools together with streaming #689

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

jmartisk
Copy link
Collaborator

Rag>
rag

Tools>
tools

@jmartisk jmartisk requested a review from iocanel June 18, 2024 09:07
@jmartisk jmartisk requested a review from a team as a code owner June 18, 2024 09:07
@jmartisk
Copy link
Collaborator Author

There's a slight problem here that streaming is always executed on the event loop, so it blows up if some of the tools are blocking. Need to figure out how to properly solve this.

@jmartisk
Copy link
Collaborator Author

There's a slight problem here that streaming is always executed on the event loop, so it blows up if some of the tools are blocking. Need to figure out how to properly solve this.

ok this should be fixed, I'm not sure if there's a better solution but I just added an assumption that tools and retrieval augmentors are blocking and should execute on a worker thread

@jmartisk
Copy link
Collaborator Author

Merging it, next I'd like to support images and do some more refactoring, the code of the page is getting really ugly

@jmartisk jmartisk merged commit b972235 into quarkiverse:main Jun 19, 2024
12 checks passed
@jmartisk jmartisk deleted the streaming branch June 19, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants