Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nightly job #703

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix the nightly job #703

merged 1 commit into from
Jun 25, 2024

Conversation

jmartisk
Copy link
Collaborator

@jmartisk jmartisk commented Jun 25, 2024

to override the langchain4j.version to the correct snapshot that was just built from the langchain4j repository

Fixes #701

@jmartisk jmartisk requested a review from a team as a code owner June 25, 2024 06:57
@jmartisk
Copy link
Collaborator Author

jmartisk commented Jun 25, 2024

Let's wait until a run in my fork completes, as a way to test that it's correct (it should fail though due to the recent incompatible changes)

@jmartisk
Copy link
Collaborator Author

jmartisk commented Jun 25, 2024

Ok, it failed successfully (failed in the way it was supposed to fail) 😆

@jmartisk jmartisk merged commit de7c673 into quarkiverse:main Jun 25, 2024
12 checks passed
@jmartisk jmartisk deleted the fix-nightly-job branch June 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly build against langchain4j main doesn't actually use the main branch
2 participants