Add a warning about missing -parameters flag for javac #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
changed the title
|
@jmartisk if you don't have time to look at the Neo4j failures, let me know please so I can disable them |
|
@geoand Hmmm supercool, another problematic embedding store that just stops working? I'll look into it asap, but feel free to disable for now |
I'll wait a little in case you come up with an easy fix :) |
jmartisk
approved these changes
Jul 2, 2024
|
Ok I can't even reproduce it locally, this will be tricky |
|
I think it's something with neo4j, because with |
Without this warning, users can end up with only an error complaining about a duplicate null key
geoand
force-pushed
the
parameters-warning
branch
from
9b858d4
to
e3709e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this warning, users can end up with only an
error complaining about a duplicate null key
This was prompted by https://stackoverflow.com/q/78695273/2504224, but it's
far from the first time I've seen the same issue.