Redis embedding store: metadata filtering #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
force-pushed
the
redis-metadata-filtering
branch
from
19a7c10
to
1031242
Compare
geoand
approved these changes
Jul 2, 2024
jmartisk
force-pushed
the
redis-metadata-filtering
branch
from
1031242
to
39ce55c
Compare
jmartisk
force-pushed
the
redis-metadata-filtering
branch
from
39ce55c
to
db6d0d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a breaking change as it splits the
quarkus.langchain4j.redis.metadata-fieldsproperty intoquarkus.langchain4j.redis.numeric-metadata-fieldsandquarkus.langchain4j.redis.textual-metadata-fields. It is important to differentiate numeric and text fields for proper indexing and to allow filteringThis filtering currently only supports filtering on numeric fields. I haven't yet figured out how to implement an exact-match equals operation on the whole value of a string field, rather than a keyword/fulltext search...