Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ollama Role serialization in lower case, fix issue with Ollama 0.2.5 #744

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Ollama Role serialization in lower case, fix issue with Ollama 0.2.5 #744

merged 1 commit into from
Jul 15, 2024

Conversation

humcqc
Copy link
Contributor

@humcqc humcqc commented Jul 15, 2024 •
edited

Ollama Role serialization in lower case, fix issue with Ollama 0.2.5

Fix: #743

@humcqc humcqc requested a review from a team as a code owner July 15, 2024 14:53
@humcqc humcqc mentioned this pull request Jul 15, 2024
Closed
geoand
geoand approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 5655986 into quarkiverse:main Jul 15, 2024
12 checks passed
@humcqc humcqc deleted the role_serialization branch July 15, 2024 16:19
@geoand
Copy link
Collaborator

geoand commented Jul 15, 2024

I released with 0.16.3 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ollama version > 0.2.5 : Role should be sent in lowercase
2 participants
@humcqc @geoand