Skip to content

Commit

Permalink
fix: make sure we run after the AddNamespaceDecorator
Browse files Browse the repository at this point in the history
The reason for this is that the `AddNamespaceDecorator` will overwrite
any namespaces we might have set on our `RoleBindings` if we let it run
after this decorator. Proper behavior for the `AddNamespaceDecorator`
should be to not overwrite namespaces if they have been set.
  • Loading branch information
metacosm committed Dec 12, 2022
1 parent dd37f04 commit ac1dd65
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,10 @@ private void outputWarningIfNeeded(String controllerName, String crBindingName,
controllerName, crBindingName);
}
}

@Override
@SuppressWarnings("unchecked")
public Class<? extends Decorator>[] after() {
return new Class[] { AddNamespaceDecorator.class };
}
}

0 comments on commit ac1dd65

Please sign in to comment.