Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassUtils.getKnownReconcilers should only return processable reconcilers #236

Closed
metacosm opened this issue Feb 14, 2022 · 0 comments · Fixed by #237
Closed

ClassUtils.getKnownReconcilers should only return processable reconcilers #236

metacosm opened this issue Feb 14, 2022 · 0 comments · Fixed by #237
Assignees
@metacosm
Labels
enhancement New feature or request

Comments

@metacosm
Copy link
Member

Right now, OperatorSDK takes care of excluding some of the non-processable reconcilers (e.g. the ones that are not correctly parameterised) but that logic should be shared.
@metacosm metacosm added the enhancement New feature or request label Feb 14, 2022
@metacosm metacosm self-assigned this Feb 14, 2022
metacosm added a commit that referenced this issue Feb 14, 2022
@metacosm
feat: getKnownReconcilers now only returns processable reconcilers
9754c86 
Fixes #236
@metacosm metacosm mentioned this issue Feb 14, 2022
Merged
@metacosm metacosm linked a pull request Feb 14, 2022 that will close this issue
Clean-ups and bug fixes #237
Merged
metacosm added a commit that referenced this issue Mar 1, 2022
@metacosm
feat: getKnownReconcilers now only returns processable reconcilers
8f3164c 
Fixes #236
metacosm added a commit that referenced this issue Mar 1, 2022
@metacosm
feat: getKnownReconcilers now only returns processable reconcilers
725e4ca 
Fixes #236
metacosm added a commit that referenced this issue Mar 30, 2022
@metacosm
feat: getKnownReconcilers now only returns processable reconcilers
2f133db 
Fixes #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean-ups and bug fixes quarkiverse/quarkus-operator-sdk
1 participant
@metacosm