Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime namespaces are not set if annotation sets namespaces during build time #725

Closed
jcechace opened this issue Sep 23, 2023 · 1 comment · Fixed by #784
Closed

Runtime namespaces are not set if annotation sets namespaces during build time #725

jcechace opened this issue Sep 23, 2023 · 1 comment · Fixed by #784

Comments

@jcechace
Copy link
Contributor

The condition here is ultimately always false when ControllerConfig annotation sets namespaces (see here)

Additionally the current implementation takes into account only the operator level property so any QUARKUS_OPERATOR_SDK_CONTROLLERS_<NAME>_NAMESPACES won't have any effect it seems.

Note: Removing ControllerConfig.namespaces from the reconcilier will make the operator level runtime config work as expected. However this leads to another set of issues which I'm gonna skip to keep this report cleaner.

@jcechace
Copy link
Contributor Author

BTW: No luck fixing it so far -- I still don't understand how / where QUARKUS_OPERATOR_SDK_CONTROLLERS_<NAME>_NAMESPACES are set in the code and how to access that value. It doesn't seem that they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant