Attempt at minimal CSV generation #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a sync commit. The idea is that we need to be able to read any existing roles or deployments to add that information to the generated CSV. However, so far, either the CSV generation occurs before the manifests are generated, doesn't occur at all or introduces a build item cycle (which is the case with this specific version of the code).
This relies on newly introduced GeneratedKubernetesResourceBuildItem from quarkusio/quarkus#20113 which would need to be backported.
This uses the new CSVGroupName annotation: all controllers using the same value for this annotation will be gathered into the same CSV. This only works with a single maven module, though.
Renamed CSVGroupName to CSVMetadata and added more fields. Introduced the SharedCSVMetadata interface that controllers wishing to share metadata, and therefore be part of the same generated CSV, need to implement, parameterized by an object that needs to be annotated with @CSVMetadata. It's still possible to annotate controllers with CSVMetadata directly or even override values from SharedCSVMetadata by individual values found in the direct CSVMetadata annotation. The name field from CSVMetadata controls the name of the generated CSV so all controllers using the same CSVMetadata.name will be part of the same generated CSV file.
Still need to make sure we only output these permissions if they're not defined in fragments, which should take precedence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.