Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query param remove double "?" generation #144

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

eformat
Copy link
Contributor

@eformat eformat commented Nov 5, 2021

fixes #143

Use a @QueryParam for the type to avoid double "?" and "%3F" in URI:

previously was:

2021-11-05 16:14:45,396 DEBUG [org.apa.htt.imp.exe.MainClientExec] (EventHandler-jokecontroller) Executing request GET /joke/Any/any%3Ftype=single?blacklistFlags=nsfw%2Cracist%2Csexist&safe-mode=false HTTP/1.1

now:

DEBUG [org.apa.htt.wire] (EventHandler-jokecontroller) http-outgoing-0 >> "GET /joke/Any/any?blacklistFlags=nsfw%2Cracist%2Csexist&safe-mode=false&type=single HTTP/1.1[\r][\n]"

Copy link
Member

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you.

@metacosm
Copy link
Member

metacosm commented Nov 5, 2021

You need to reformat your code, though.

@eformat
Copy link
Contributor Author

eformat commented Nov 5, 2021

@metacosm ah yup, mvn formatter:format - done. cheers.

@metacosm metacosm merged commit 124fff0 into quarkiverse:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples - Joke is not always written back to CR
2 participants