Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add mysql-schema sample (devservices) #221

Merged
merged 3 commits into from
Feb 9, 2022
Merged

test: add mysql-schema sample (devservices) #221

merged 3 commits into from
Feb 9, 2022

Conversation

scrocquesel
Copy link
Member

Alternative to #201 using Quarkus DevServices (test containers) instead of mocking mysql service class.

@metacosm
Copy link
Member

metacosm commented Feb 7, 2022

Do you think we should have both versions of the test?

@scrocquesel
Copy link
Member Author

Do you think we should have both versions of the test?

No. it works the same and it promotes usage of devservices. It's just a bit slower to run.

@metacosm
Copy link
Member

metacosm commented Feb 7, 2022

So, to be clear: this is the PR you want merged and not the other one?

@scrocquesel scrocquesel mentioned this pull request Feb 7, 2022
4 tasks
@scrocquesel
Copy link
Member Author

i'm rebasing

@scrocquesel
Copy link
Member Author

This sample has proved useful. See #225

@metacosm metacosm merged commit f02af21 into quarkiverse:main Feb 9, 2022
@scrocquesel scrocquesel deleted the test/devservices branch March 3, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants