Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly register reconciler-associated classes for reflection #435

Merged
merged 3 commits into from
Oct 26, 2022
Merged

fix: properly register reconciler-associated classes for reflection #435

merged 3 commits into from
Oct 26, 2022

Conversation

metacosm
Copy link
Member

  • fix: only generate all CRD if we should generate CRDs at all
  • fix: use proper logger as it is less confusing
  • fix: reconciler info also returns associated CR info for reflection

@metacosm metacosm added the bug Something isn't working label Oct 25, 2022
@metacosm metacosm self-assigned this Oct 25, 2022
@metacosm metacosm mentioned this pull request Oct 25, 2022
Closed
@metacosm metacosm force-pushed the fix-reflection-registration branch from 41ac9ba to aca4ce9 Compare October 25, 2022 18:40
@metacosm metacosm force-pushed the fix-reflection-registration branch from aca4ce9 to d798eb9 Compare October 25, 2022 18:41
@metacosm metacosm merged commit 63012fe into main Oct 26, 2022
@metacosm metacosm deleted the fix-reflection-registration branch October 26, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metacosm metacosm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metacosm