fix: use deployment namespace if provided when generating RoleBindings #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
metacosm
commented
Dec 12, 2022
metacosm
commented
- fix: use deployment namespace if provided when generating RoleBindings
- fix: make sure we run after the AddNamespaceDecorator
- chore: test that different deployed in / watched namespaces works
The reason for this is that the `AddNamespaceDecorator` will overwrite any namespaces we might have set on our `RoleBindings` if we let it run after this decorator. Proper behavior for the `AddNamespaceDecorator` should be to not overwrite namespaces if they have been set.
metacosm
force-pushed
the
ns-role-binding
branch
from
8c0075f to
780a654
Compare
…orks" This reverts commit 780a654.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.