Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: status detection in non-CR resources #675

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: status detection in non-CR resources #675

merged 1 commit into from
Aug 14, 2023

Conversation

metacosm
Copy link
Member

Fixes #673

@metacosm metacosm self-assigned this Aug 10, 2023
@metacosm metacosm requested a review from csviri August 10, 2023 14:48
csviri
csviri approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit b39c1fb into main Aug 14, 2023
@metacosm metacosm deleted the status-detection branch August 14, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status detection is only implemented for Custom Resources leading to improper RBACs for built-in resources
2 participants
@metacosm @csviri