Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a CSV.spec.version value when possible #686

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

metacosm
Copy link
Member

Fixes #682

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes #682
@metacosm metacosm self-assigned this Aug 16, 2023
@metacosm metacosm requested a review from csviri August 16, 2023 15:10
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one strageness with imports, otherwise LGTM, although will need to dig deeper in this part

@metacosm metacosm merged commit bddef54 into main Aug 17, 2023
@metacosm metacosm deleted the fix-682 branch August 17, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterServiceVersion.spec.version might be required
2 participants