fix: helm chart generates invalid YAML when watching all namespaces #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a reconciler is configured to watch all namespaces, a ClusterRoleBinding object is generated by AddRoleBindingsDecorator, and it later gets appended to templates/kubernetes.yml by HelmChartProcessor. However, that file becomes syntactically invalid because FileUtils.asYaml produces a top-level YAML array when passed a List. That's not what Helm expects. When one tries to install the generated chart, the following error is returned: Error: INSTALLATION FAILED: YAML parse error on [...]/templates/kubernetes.yml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go value of type releaseutil.SimpleHead YAML parse error on [...]/templates/kubernetes.yml
|
@csviri I wonder if the ClusterRoleBinding doc shouldn't be filtered out by |
|
I thought some more about this and figured that it made sense to exclude the generated cluster role binding. I added another commit that excludes it, and enhances the test to produce some custom resources and check that they all get appended to kubernetes.yml. |
metacosm
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a reconciler is configured to watch all namespaces, a ClusterRoleBinding object is generated by
AddRoleBindingsDecorator, and it later gets appended to templates/kubernetes.yml by HelmChartProcessor.
However, that file becomes syntactically invalid because FileUtils.asYaml produces a top-level YAML array when passed a List. That's not what Helm expects.
When one tries to install the generated chart, the following error is returned: