feat: make adding a main application optional #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since most operator applications don't really need to do anything in the main method besides calling `start` on Operator, make it possible to not provide a `QuarkusApplication` at all, thus removing more boilerplate.
geoand
reviewed
Jul 30, 2021
|
|
||
| // if the app doesn't provide a main class, add the StartupListener | ||
| if (index.getAllKnownImplementors(DotName.createSimple(QuarkusApplication.class.getName())).isEmpty()) { | ||
| additionalBeans.produce(AdditionalBeanBuildItem.unremovableOf(StartupListener.class)); |
There was a problem hiding this comment.
Actually, you might want to add the scope here, which is likely @Singleton
There was a problem hiding this comment.
Better to add the scope on the class or add it when the bean is produced?
There was a problem hiding this comment.
Since you are conditionally registering it as a bean, I propose doing it here
metacosm
force-pushed
the
add-startup-listener
branch
from
136b8ee to
7ae4cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most operator applications don't really need to do anything in the
main method besides calling
starton Operator, make it possible to notprovide a
QuarkusApplicationat all, thus removing more boilerplate.