Apply CRD when changes happened during dev that impact them #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that CRDs can be applied even if they haven't been generated in the current live reload. Also fixed wrong parameters order when constructing CRDGenerationInfo.
Record which CRD got generated so that we can apply only the ones that have changed when we register the controller. Also make sure that delayed registration controllers follow the same logic with respect to CRD application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is controlled by the
quarkus.operator-sdk.crd.applyproperty. When set totrue, any change impacting the CRD will trigger a regeneration and apply the new CRD to the cluster automatically.Fixes #11
Fixes #12