Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include missing XMLBeans schemas in the native image #60

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Include missing XMLBeans schemas in the native image #60

merged 2 commits into from
Jun 1, 2023

Conversation

knuspertante
Copy link
Contributor

@knuspertante knuspertante commented May 31, 2023 •
edited by gastaldi
Loading

@knuspertante knuspertante mentioned this pull request May 31, 2023
Closed
@melloware melloware force-pushed the bug/shapelayoutelement branch from b13bedd to 12b807a Compare May 31, 2023 21:15
@melloware
Copy link
Contributor

Build is running now.

@gastaldi
Copy link
Member

gastaldi commented May 31, 2023 •
edited
Loading

Can you format the sources using mvn clean process-sources?

Formatted changes pushed

@gastaldi gastaldi force-pushed the bug/shapelayoutelement branch from 12b807a to c393c3c Compare May 31, 2023 23:30
@gastaldi gastaldi changed the title reproduce missing schemas Include missing XMLBeans schemas in the native image May 31, 2023
@gastaldi gastaldi force-pushed the bug/shapelayoutelement branch from f964876 to 4986aa0 Compare May 31, 2023 23:36
@gastaldi gastaldi requested a review from a team May 31, 2023 23:36
@gastaldi
Copy link
Member

@all-contributors add @knuspertante for bug and test

@allcontributors allcontributors bot mentioned this pull request May 31, 2023
Merged
@allcontributors
Copy link
Contributor

@gastaldi

I've put up a pull request to add @knuspertante! 🎉

@gastaldi
Copy link
Member

@knuspertante I pushed the fix to your branch and renamed the PR (hope you don't mind) 😄
Can you give it a shot?

Also I'd appreciate the feedback from the @quarkiverse/quarkiverse-poi team 😉

melloware
melloware approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Michael Schilling and others added 2 commits May 31, 2023 22:10
@gastaldi
add special_file and test
dfee950 
Include `xsb` files in the native image

Co-Authored-By: George Gastaldi <gegastaldi@gmail.com>
@gastaldi
Using quarkus-resteasy-reactive in the integration test
8311651
@gastaldi gastaldi force-pushed the bug/shapelayoutelement branch from 34e30c2 to 8311651 Compare June 1, 2023 01:11
@knuspertante
Copy link
Contributor Author

@gastaldi thanks! LGTM and works very well!

That's funny, because the missing resource was also my first thought but after i monitored the jvm mode with the tracing agent, this entry was not included in the resource-config.json.
That's why I thought it can't be that and the xsb are already compiled as a class.

Thanks for adding me as a contributor, I appreciate that!

@gastaldi @melloware I think this could be merged or do I have to do something, like rename the test / file, clean up the commit history, ... ?

@melloware melloware merged commit 2abdcb7 into quarkiverse:main Jun 1, 2023
@melloware
Copy link
Contributor

I squashed it for you!

@gastaldi
Copy link
Member

gastaldi commented Jun 1, 2023

@melloware fancy backporting this to 1.x and releasing both?

@melloware
Copy link
Contributor

yep i will put it on my list today!

gastaldi pushed a commit that referenced this pull request Jun 1, 2023
@knuspertante @gastaldi
Include missing XMLBeans schemas in the native image (#60)
6143cee
@gastaldi gastaldi mentioned this pull request Jun 1, 2023
Merged
melloware pushed a commit that referenced this pull request Jun 1, 2023
@gastaldi @knuspertante
[backport] Include missing XMLBeans schemas in the native image (#64)
f74e5b1 
* Include missing XMLBeans schemas in the native image (#60)

* Bump quarkiverse-parent to 14

---------

Co-authored-by: Michael Schilling <32802753+knuspertante@users.noreply.github.com>
@knuspertante knuspertante deleted the bug/shapelayoutelement branch June 6, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native-Image Schema is missing: org.apache.poi.schemas.ooxml.system.ooxml.shapelayoutelement
3 participants
@knuspertante @melloware @gastaldi