-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolidJS: update docs for configuration #711
Comments
Is this needed?
|
Ok, yes. So, for Solid.js you need to set
For it to override the index html redirect to If you do not set the REST path for an
then you SHOULD set the following to avoid 404 in
And if you want Quarkus to hit the 404 page, then don't set SPA mode, otherwise set SPA mode for the other paths in your app. Here I need to test more with a router, as currently I just created an empty solidjs app so far. Might also need |
Hmm we should update the docs for solid but I know others are using solid without issue like this user: #705 |
Oh that is you! Make sure you check the docs about SPA. |
But a PR would be great to update the docs we have other framework specific instructions we should add a Solid section here: https://docs.quarkiverse.io/quarkus-quinoa/dev/web-frameworks.html#_required_configuration |
@melloware sure thing. Yet, the docs don't even mention this setting:
Nor do the docs explain why the sample app has the |
Isn't that documented right here: https://docs.quarkiverse.io/quarkus-quinoa/dev/config-reference.html#quarkus-quinoa_quarkus-quinoa-dev-server-index-page Also i think the issue you are having is the CodeStart is just to show you how it works. You don't need anything in that package.json you would rip the whole web-ui out for your own project and its dependencies. Like from a Solid Start example. For example I am using Farm in a React app with Quinoa here: https://github.com/melloware/quarkus-primereact Take a look at my |
Can you try this? Just unzip and run This is a Solid app running under Quinoa: |
what does "different" mean? it is the same for dev-server as production. But you have to set this setting because Quarkus thinks that if you do not have an index.html in the resources directory then you must want to go to the This is a setting that must always be set for all frameworks, no? Other than the work around in the sample non-framework Vite app which tries to do this via an express plugin, but I don't think that works either. If you go to and related: So isn't this setting REQUIRED in dev mode? maybe it should always be set to |
Did you try my Solid app above? It needs no custom props and works out of the box? |
That solid-start app seems to behave better than the solid.js w/vite app that I was trying. I upgraded to latest Quarkus 3.12.1, changed I removed the SPA routing class work-around from that after upgrading as it seems to work fine without it. That solid-start is very outdated, so will try with current as well, but need to replace the code as it has significant differences. But assuming it will work ok. And correct, no custom props, works (the dev server must return better information than solidjs w/vite by itself was returning to block the I'll try solid-start 1.0.2 which is current and report back. |
Ok, solid-start 1.0.2 works fine without custom props, only SolidJS vite template doesn't. I'm fine with that, I prefer solid-start. BUT, there is one change needed for Solid-Start since 1.0.x or so, is that build outputs to So this setting needed for current solid-start:
|
I'll post zip here in a moment, with modern Gradle, current everything, solid-start 1.0.2 build. |
Here it is: That is current quarkus, current quinoa, current Kotlin, current solid-start, current Gradle thanks for your patience and help! |
Links in that example to test: Solid-Start app: API:
DEV-UI: |
Nice! Yeah the reason you have to use Solid Start its its a UI only library where Solid itself won't work because its serving its own pages and renderer. Quinoa only supports client side libraries and Solid i believe wants to be the HTTP server and render its pages. |
See my PR: #712 Vinxi for Solid Start will need no custom configuration after that change |
is dev mode is more silent, creates nothing that I know of. |
Hmm ok let me look. .output is a weird choice by them. |
Ok fixed in master |
Describe the bug
Even using a sample quinoa-app, and doing something similar in a new app, all requests just end up redirecting to the Quarkus development UI, because there is no
index.html
in the/META-INF/resources
directory. This is coded in Quarkus with no configuration option to disable it, and Quinoa does not override it.It is also not clear if custom express middleware is needed as shown in the quinoa-codestart sample:
https://github.com/quarkiverse/quarkus-quinoa/blob/main/runtime/src/main/codestarts/quarkus/quinoa-codestart/base/src/main/webui/vite.config.js#L9
Create app with:
quarkus create app quinoa-app -x=io.quarkiverse.quinoa:quarkus-quinoa
And this only works on
http://localhost:8080/quinoa.html
and even if setting the SPA configuration to true still redirects to dev UI athttp://localhost:8080/
It just isn't clear how to get index.html working with something like Solid.js or even your sample working from
index.html
(other thanquinoa.html
)And again, this create app has all the custom express handling which is not mentioned in the docs at all. Is it needed? not needed?
Regardless, can't get
http://localhost:8080/
to work for the hosted webuiQuinoa version
2.4.1
Quarkus version
3.12.1
Build / Runtime
Vite
Package Manager
PNPM
Steps to reproduce the behavior
see above
Expected behavior
http://localhost:8080/
goes to the webui and not the quarkus dev uiThe text was updated successfully, but these errors were encountered: