Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make indexPage value to empty string when configured with value "/" #401

Merged
merged 1 commit into from
Jun 26, 2023
Merged

make indexPage value to empty string when configured with value "/" #401

merged 1 commit into from
Jun 26, 2023

Conversation

fblan
Copy link
Contributor

@fblan fblan commented Jun 26, 2023

Describe your changes

replace QuinoaHandlerConfig by an empty string when it is configured to "/"

Fixes Issue

Closes #391

Check List (Check all the applicable boxes)

  • [x ] My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • [x ] All new and existing tests passed.

ia3andy
ia3andy approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fblan

@melloware melloware merged commit f9a0e89 into quarkiverse:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sveltekit framework support
3 participants
@fblan @ia3andy @melloware