Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Big refactor and improvements code and doc #511

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

ia3andy
Copy link
Collaborator

@ia3andy ia3andy commented Sep 20, 2023

  • Changed config:
    • quarkus.quinoa.frozen-lockfile => quarkus.quinoa.ci
    • Dropped quarkus.quinoa.package-manager-command.prepend-binary (this is always the default behavior now to make it compatible/consistant with package-manager install)
    • Added quarkus.quinoa.dev-server.index-page to override the index page but only for the dev-server
    • Added quarkus.quinoa.framework.detection to allow disabling framework detection
  • Fixes Improve doc, split pages add nav #413
  • Refactor code which slowly got a bit too complex with time
  • Allow to create really precise Framework overrides and logging instructions. For example, NextJs is working out of the box with instructions if something is missing from the config:
2023-09-20 18:05:21,665 INFO  [io.qua.qui.dep.fra.FrameworkType] (build-16) Quinoa detected 'NEXT' framework from package.json file.
2023-09-20 18:05:21,665 WARN  [io.qua.qui.dep.fra.ove.NextFramework] (build-16) Update your package.json with: '"build": "next build && next export"' to make Next compatible with Quinoa.

@ia3andy ia3andy changed the title Big refactor Big refactor and improvements code and doc Sep 20, 2023
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except it looks like the build is failing?

@ia3andy ia3andy changed the title Big refactor and improvements code and doc [Breaking Change] Big refactor and improvements code and doc Sep 21, 2023
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great refactor!

@melloware melloware added this to the 2.1.1 milestone Sep 21, 2023
@ia3andy ia3andy merged commit b8944ab into quarkiverse:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve doc, split pages add nav
2 participants