-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Framework detection and tests #523
Conversation
a73a43d
to
73a6f3d
Compare
@melloware this is another large PR but I think it is another good bunch of improvements for detection and logging |
16932ac
to
36cfa06
Compare
36cfa06
to
7390abc
Compare
This is what the test run prints:
|
|
||
private static final Logger LOG = Logger.getLogger(FrameworkTypeTest.class); | ||
|
||
@ParameterizedTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of parameterized test!
import java.util.Objects; | ||
import java.util.Optional; | ||
import java.util.Set; | ||
import java.util.StringJoiner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just learned something new. I have been using Commons Lang StringUtils.join
for years didn't know it was in the JDK now!
Fixes #520 #519