Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESBuild builder detected with last versions of angular framework #716

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

yatho
Copy link
Contributor

@yatho yatho commented Jul 12, 2024

Describe your changes

I have added the check of angular builder used in the web project to check if the project use EsBuild or Webpack. With EsBuild a /browser folder was added in dist directory during the build.

Fixes Issue

Closes #579

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@yatho
Copy link
Contributor Author

yatho commented Jul 12, 2024

@ia3andy I have done the PR about Angular build path as we talked at RivieraDev. Enjoy to read your comments.

@melloware melloware added this to the 2.4.2 milestone Jul 12, 2024
@melloware melloware added the enhancement New feature or request label Jul 12, 2024
@melloware melloware requested a review from ia3andy July 12, 2024 18:45
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yatho ! I will let @ia3andy chime in but this looks good to me.

@melloware
Copy link
Contributor

@all-contributors add @yatho for code

Copy link
Contributor

@melloware

I've put up a pull request to add @yatho! 🎉

Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @yatho :)

Right @melloware ?

@melloware
Copy link
Contributor

yep it looks great to me!

@melloware melloware merged commit a3e1e36 into quarkiverse:main Jul 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 17 Framework Support
3 participants