Release 0.1.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpasson hey, the quarkiverse-docs is still a prototype and we're evaluating it. Here is an example on how to have your extension listed there: quarkiverse/quarkiverse-docs#1 |
|
@gastaldi ok, I will send a PR then to include the quarkus-rabbitmq-client in there. |
gastaldi
approved these changes
Jan 27, 2021
|
As stated I still have to test TLS connections in java and native mode. I would like to have some actual integration tests. Is there a way to spin up an actual RabbitMQ during the build? Not too familiar with GitHub actions yet. |
|
I haven't tested, but I think you can use TestContainers for that: https://www.testcontainers.org/modules/rabbitmq/ |
|
Why didn't I think of that. I'll give it a go and see if I can get that up and running. |
loicmathieu
suggested changes
Jan 28, 2021
runtime/src/main/java/io/quarkiverse/rabbitmqclient/RabbitMQReadyCheck.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/io/quarkiverse/rabbitmqclient/RabbitMQClientProducer.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/io/quarkiverse/rabbitmqclient/RabbitMQClientProducer.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/io/quarkiverse/rabbitmqclient/deployment/QuarkusRabbitmqClientProcessor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial version of the RabbitMQ client. It contains full documentation on how to use it. Not sure where I can actually view the documentation. I used quarkiverse-docs to build the documentation, but noticed font-awesome icons are not rendered. I couldn't find any documentation on how the documentation actually works. Any hints there are appreciated.
I will not be merging this until I got the chance to test the TLS connection setup with RabbitMQ in both java and native mode.
The pull request is mainly here to see if the build pipeline is working as expected and to get some feedback on the project structure and if all adheres to the Quarkiverse expectations.