Return HTTP 500 instead of 400 on ValidationException (#254) #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254 by having
ValidationExceptionMapper
return a HttpProblem withINTERNAL_SERVER_ERROR
instead ofBAD_REQUEST
.I tried deleting the
ValidationExceptionMapper
in the hope that the exception would then be handled by theDefaultExceptionMapper
, but that didn't work as it was instead handled by the exception mapper from Quarkus.Also adds an additional integration-test, checking that a HTTP 500 is returned if a subclass of
ValidationException
is thrown, and renamesValidationExceptionsResource
to fix a typo.The branch passes both
run-jvm-tests
andrun-native-tests
, but fails when running./mvnw verify
with an exception:However, as the
master
branch fails with the same exception on my machine, I assume it's unrelated to the changes made in this branch.