Fix for: Exception occurring when encoding the path containing unwise characters (i.e space) #364
Conversation
| return null; | ||
| } | ||
| try { | ||
| return new URI(context.path.replaceAll(" ", "%20")); |
There was a problem hiding this comment.
Question out of curiosity: shouldn't we escape whole path?
There was a problem hiding this comment.
Not sure what other options we have? Only path segment after last '/' ?
Even if - is there any harm to keep it simple with replaceAll?
There was a problem hiding this comment.
As usual I'm referring to standards ;)
In RFC2396 (URI spec) you can find unwise characters that required escaping.
unwise = "{" | "}" | "|" | "\" | "^" | "[" | "]" | "`"
Might not be worth doing it in this scenario though.
There was a problem hiding this comment.
Thanks for details @pazkooda, very good idea to properly handle all of them (i.e by using UrlDecoder/Encoder classes), please re-review, unfortunately the changes got bigger as I needed to adjust problem-to-json serializers as well.
lwitkowski
changed the title
Fixes #358