Add web/templates as a Qute template root #165
Conversation
ia3andy
force-pushed
the
template-root
branch
from
532548f
to
de1bc4a
Compare
ia3andy
force-pushed
the
template-root
branch
from
de1bc4a
to
10fcec6
Compare
| WebBundlerConfig config) { | ||
| templateRootProducer.produce(new TemplateRootBuildItem(config.fromWebRoot("templates"))); | ||
| nativeImageResourceDirectoryProducer | ||
| .produce(new NativeImageResourceDirectoryBuildItem(config.fromWebRoot("templates"))); |
There was a problem hiding this comment.
@mkouba I had to add this for Native support
There was a problem hiding this comment.
Maybe it should be done by the Qute Processor?
There was a problem hiding this comment.
Well, we do produce a NativeImageResourceBuildItem for each template found. TBH I've never seen NativeImageResourceDirectoryBuildItem before.
Also we test a native image in quarkus-qute-web.
What's the actual problem?
There was a problem hiding this comment.
@mkouba the tests were not passing in native mode
There was a problem hiding this comment.
quarkus-web-bundler tests I assume? Is there anything special in those tests?
There was a problem hiding this comment.
@phillip-kruger I think this is the origin of #172, NativeImageResourceDirectoryBuildItem might want the directory to exist (which should not lead to a NPE anyway), so I need to add a check here and maybe a fix in Quarkus
cc @angelozerr