-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option that enables Service Loading #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @geoand Thank you very much for your contribution. I only have a few little things 💪
deployment/src/main/java/io/quarkiverse/wiremock/devservice/WireMockServerBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
...rc/test/java/io/quarkiverse/wiremock/devservice/WiremockExtensionServiceLoadingDisabled.java
Show resolved
Hide resolved
@@ -0,0 +1,2 @@ | |||
quarkus.wiremock.devservices.global-response-templating=true | |||
quarkus.wiremock.devservices.extension-scanning-enabled=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be so kind to include the new config parameter in the documentation as well - thank you very much
docs/modules/ROOT/pages/includes/quarkus-wiremock.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this meant to be updated automatically when building the project? Any idea why it wasn't updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'm aware that this works when contributing to the platform. That's why the config comments are mandatory, right? However, I haven't thought about how this should work for extensions. I've just maintained them manually. Let me check ... 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be mistaken, but I am pretty sure it work automatically. @gastaldi can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs to be changed to match the config document: https://github.com/quarkiverse/quarkus-wiremock/blob/main/docs/pom.xml#L68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gastaldi Ah damn, thanks! I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gastaldi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
The context of this is this issue where I would like to move away for custom WireMock handling to using this extension.
However in order to do so, I would need some custom code that can set parameter templates and for that I need for a custom WireMock Extension to be loaded.