Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quarkus resteasy qute extension #327

Merged

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Dec 4, 2023

This extension was removed from code.quarkus.io with 3.6. The extensions stay, just won't be showing at code.quarkus.io but now quarkus-qute-web exist which is extended version of resteasy qute and using it as dependency (+ automatically choose if use non-reactive or reactive). For more detail see quarkusio/quarkus#37478 and quarkusio/quarkus#37000

We have one occurrence also here https://github.com/quarkus-qe/quarkus-startstop/blob/main/testsuite/src/it/java/io/quarkus/ts/startstop/ArtifactGeneratorTest.java#L161 but I tested it and it not fail as it use command line and not website.

@jedla97 jedla97 requested a review from rsvoboda December 4, 2023 12:12
@jedla97
Copy link
Member Author

jedla97 commented Dec 4, 2023

Moving to draft as per last comment quarkusio/quarkus#37478 (comment) the extension will be available for now in code quarkus adn removing will target 3.7

@jedla97 jedla97 marked this pull request as draft December 4, 2023 12:41
@rsvoboda rsvoboda marked this pull request as ready for review December 4, 2023 13:02
@rsvoboda
Copy link
Member

rsvoboda commented Dec 4, 2023

Please check code.quarkus fail, the rest can be imho ignored for now

@jedla97
Copy link
Member Author

jedla97 commented Dec 4, 2023

It's says the native was take longer that set timeout. I run it locally few time and no issue. Run it with GH action on my branch 3 times also no issue. So I think it was just intermittent.

@rsvoboda rsvoboda merged commit 1b176aa into quarkus-qe:main Dec 4, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants