Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.z] Bump Quarkus and Quarkus config version to 3.2.12.Final, remove helm and disable CLI test #1095

Merged
merged 3 commits into from
May 11, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Apr 21, 2024

Summary

Update Quarkus version to 3.2.12.Final

Backport helm removal as this was breaking windows CI execution.

Disable CLI test as they are affected by quarkusio/quarkus#37808

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Apr 21, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented Apr 23, 2024

Windows was failing because of helm which was removed in main, backporting this commit

@jedla97
Copy link
Member Author

jedla97 commented May 10, 2024

CLI error are caused by quarkusio/quarkus#37808 (wasn't been backported to 3.2) this should not affect newer Quarkus version. Try it localy with the bugfix for cli, there is needed slight modification to compile (on quarkus side).

@jedla97
Copy link
Member Author

jedla97 commented May 10, 2024

run tests

@jedla97 jedla97 changed the title [1.3.z] Bump Quarkus and Quarkus config version to 3.2.12.Final [1.3.z] Bump Quarkus and Quarkus config version to 3.2.12.Final, remove helm and disable CLI test May 11, 2024
@jedla97 jedla97 requested a review from michalvavrik May 11, 2024 09:21
Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michalvavrik michalvavrik merged commit 446cd7a into quarkus-qe:1.3.z May 11, 2024
9 checks passed
@michalvavrik
Copy link
Contributor

michalvavrik commented May 11, 2024

CLI error are caused by quarkusio/quarkus#37808 (wasn't been backported to 3.2) this should not affect newer Quarkus version. Try it localy with the bugfix for cli, there is needed slight modification to compile (on quarkus side).

Should we at least let them know about this? I approved as this is FW, so disabled test inside FW doesn't bother me (we have TS to verify RHBQ), but maybe we should be good citizens? I'll leave decision to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants