-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build-time config detection for relocated properties and for config properties from extension deployment modules #1154
Fix build-time config detection for relocated properties and for config properties from extension deployment modules #1154
Conversation
run tests |
e990536
to
bc49272
Compare
run tests |
|
How often do we need to have the list updated? Is there any noticeable milestone? Maybe adding a note into https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md#preconditions for new major/minor releases? CC @mjurc |
strange how it is most of the build-time and build-time-fixed properties are placed in classes in the runtime modules (for build-time it's waste...). and there, it is still automated. then it is not going to fail as long as other bulid-time property or custom class/dependency is detected. so I'd say:
Honestly, we had build-time list for years and we only updated it when we had failing tests. I suppose I could write a workflow that updates it periodically but we don't have this kind of time. I think we should update it when there is a failure and then when we have a time. JVM build failure goes down to the quarkusio/quarkus#36826 |
Cool, seems it's fine to have this as adhoc action.
Worth GH issue? |
I run quick check and only found 6 examples of this. However additionally, build-time-runtime-fixed is placed in the runtime so it is auto-detected. as for opening issue - sadly config classes are treated as part of the API now, which is one of the reasons why there is so long process of migrating config classes to config mapping interfaces (in addition to reflection registration effectiveness), so:
|
What failure? The CI failure? |
We have one build failure in the |
Not a bug |
got it, thanks for your time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just verifying - the CI failure is caused by wrong Quarkus platform bom version in action?
we need the plugin to use correct version, Jakub tries to address it here #1157 (I'll review soon); I wouldn't be worried about this failing as this PR is not specific to Quarkus version and released version was green. |
Summary
closes: #1149
the script is based on https://github.com/quarkusio/quarkus/blob/main/docs/src/main/java/io/quarkus/docs/generation/AllConfigGenerator.java
Please check the relevant options
run tests
phrase in comment)Checklist: