Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle config secrets during build-time config detection #1160

Conversation

michalvavrik
Copy link
Member

Summary

addresses: quarkus-qe/quarkus-test-suite#1820 (comment)

All interceptors are registered by default and we don't create config ourselves, so cannot avoid registering secrets. It's irrelevant for build-time config detection.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix! LGTM, CI is green and have quick run with affected testsuite test and it's works.

@jedla97 jedla97 merged commit 209ab82 into quarkus-qe:main Jun 5, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-config-secrets-for-build-config-detection branch June 5, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants