Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-time config race on Windows for DEV mode tests of our monthly test run #1170

Conversation

michalvavrik
Copy link
Contributor

@michalvavrik michalvavrik commented Jun 13, 2024

Summary

DEV mode tests in Windows monthly test run are failing as command line arguments are computed based on build-time properties. These arguments are required in a different flow (native executable build) where the build-time properties are already present.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michalvavrik michalvavrik merged commit 9a1ea79 into quarkus-qe:main Jun 13, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-build-time-detection-on-wind branch June 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants