Update deprecated method in OpenShiftClient #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedla97
force-pushed
the
remove-deprecated-methods
branch
from
72a5fbe
to
cf5775c
Compare
|
run tests |
1 similar comment
|
run tests |
|
@mjurc do you think the fail in OCP native is related to the change? |
|
@rsvoboda I saw this failiure few times in past. That test is flaky/need more time don't know. But I tested it with testsuite and saw few failiures, but didn't have time to investegate them. But this PR is still on my radar and will finish it when I'll have some spare hours. |
|
Hey, I just used this PR to check that the credentials in the workflow worked proper - sorry about that |
jedla97
force-pushed
the
remove-deprecated-methods
branch
2 times, most recently
from
43aaf89
to
36f2900
Compare
jedla97
force-pushed
the
remove-deprecated-methods
branch
from
36f2900
to
53845d9
Compare
|
run tests |
1 similar comment
|
run tests |
|
The Linux JVM is not caused by this, same as daily |
|
run tests |
mjurc
approved these changes
Sep 10, 2024
| // call createOrReplace | ||
| client.resource(groupModel).createOrReplace(); | ||
| // call createOr and if it exists the update will be done | ||
| client.resource(groupModel).unlock().createOr(NonDeletingOperation::update); |
There was a problem hiding this comment.
Gee, I am surprised there's actually an elegant solution like this. Thank you!
|
Let's try it :) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing deprecated methods
createOrReplace()andyamlMapper()from OpenShiftClientTested this version with testsuite weekly stable ocp and test was passing except know issues.
The
createOrReplacewas replaced bycreateOrand update is now provided byNonDeletingOperation::updateorNonDeletingOperation::patch. This was recomnded by official FAQ.I decided to use the unlock even as it's optional as per explanation it's needed if the
resourceVersionhas value.The use of the unlock function is optional and is only needed if you are starting with a item that has the resourceVersion populated.For
applyServicePropertiesToDeploymentmethod I using patch as I encounter few problem when testing it. Sometime it throw that resources are outdated when applying update. In this case patch is more safe. The problem was only inconfigMapEndToEndbut it's used in multiple tests. If you want to use update insted of patch we probably need to implement some kind of retry mechanism for itThe
yamlMapperwas updated similar as they done it when removing they usage herePlease check the relevant options
run testsphrase in comment)Checklist: