Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and extend release version checker #1209

Merged

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Jul 18, 2024

Summary

Fixes problems with globbing and adds additional check of next-version in project.yml

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk marked this pull request as ready for review July 18, 2024 14:49
@gtroitsk gtroitsk force-pushed the fix/extend-release-version-checker branch from 9ccfffb to 6e5f93a Compare July 18, 2024 14:50
@gtroitsk
Copy link
Member Author

@michalvavrik do you want from me some examples of new added checks?

@michalvavrik
Copy link
Contributor

@michalvavrik do you want from me some examples of new added checks?

we had examples last time; tbh I simply don't have time span to verify this works as expected. it would be enough for me to understand how you tested it, so that we know it works.

Copy link

Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version'

@gtroitsk gtroitsk force-pushed the fix/extend-release-version-checker branch from 6e5f93a to 519ebc9 Compare July 18, 2024 17:24
@gtroitsk
Copy link
Member Author

gtroitsk commented Jul 18, 2024

Plan for 1.3.z branch during backports
It requires releasing 1.3.0, so probably change https://github.com/quarkus-qe/quarkus-test-framework/releases/tag/v1.3.0.Beta31

After, the latest version should be 1.3.1 as a blank release or changed https://github.com/quarkus-qe/quarkus-test-framework/releases/tag/1.3.1.Final

What strategy do you prefer?

@michalvavrik
Copy link
Contributor

Let's go with the easiest way, if we need 1.3.0 to have this check passing, it's better to do extra release than to invest more time into this task.

@michalvavrik michalvavrik merged commit 184dd31 into quarkus-qe:main Jul 18, 2024
7 checks passed
@gtroitsk gtroitsk deleted the fix/extend-release-version-checker branch July 18, 2024 18:17
Copy link

Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version'

@gtroitsk gtroitsk added triage/backport-1.3? Backport to 1.3 branch may be required triage/backport-1.4? Quarkus 3.8 stream labels Jul 18, 2024
@gtroitsk gtroitsk removed triage/backport-1.3? Backport to 1.3 branch may be required triage/backport-1.4? Quarkus 3.8 stream labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants