Add support for Quarkus CLI config command #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
changed the title
|
Kafka failures not related. |
michalvavrik
force-pushed
the
feature/quarkus-cli-config-command
branch
2 times, most recently
from
2e9ac30
to
87cbea0
Compare
gtroitsk
reviewed
Jul 23, 2024
...t-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusEncryptConfigCommandBuilder.java
Outdated
Show resolved
Hide resolved
gtroitsk
reviewed
Jul 23, 2024
quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusConfigCommand.java
Show resolved
Hide resolved
michalvavrik
force-pushed
the
feature/quarkus-cli-config-command
branch
from
87cbea0
to
b4b1aa3
Compare
gtroitsk
reviewed
Jul 23, 2024
quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusConfigCommand.java
Show resolved
Hide resolved
...st-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusEncryptConfigCommandResult.java
Outdated
Show resolved
Hide resolved
|
We can wait for Validate format CI run and merge. Last fix was small refactoring and I see green CI with related test before. |
makes sense, I'd like to make release today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Required for QUARKUS-3456. Full test coverage will be in TS, this commit covers every option of this PR: quarkus-qe/quarkus-test-suite@main...michalvavrik:quarkus-test-suite:feature/config-encryption-cli . Test coverage here is just a smoke test.
Please check the relevant options
run testsphrase in comment)Checklist: