Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated #1226

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 24, 2024

Summary

Updating password env variable for MSSQL as it was deprecated see note https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

@michalvavrik michalvavrik merged commit c79ff03 into quarkus-qe:main Jul 24, 2024
8 checks passed
@jedla97 jedla97 added the triage/backport-1.4? Quarkus 3.8 stream label Jul 25, 2024
@jedla97 jedla97 deleted the mssql-password branch July 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/backport-1.4? Quarkus 3.8 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants