-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for creating CLI apps from existing sources #1233
Add method for creating CLI apps from existing sources #1233
Conversation
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id> | ||
<quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id> | ||
<quarkus.platform.version>3.12.3</quarkus.platform.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 3.13.0 is out
- What about updates and prod versions? I would like to have a way to change this value without editing the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is primarily aimed at CLI update-testing. Which means - we want to use old quarkus versions, and if we need up-to-date ones - we'll use "quarkus update" to get to it.
I will add an option to use either CliDevModeVersionLessQuarkusApplicationManagedResource or CliDevModeLocalhostQuarkusApplicationManagedResource (similar to #1232) but I can see potential problems here. See if I have an app with git-anchored sources, then those sources are probably made for specific version of quarkus and changing it to newer version, would possibly require to update the sources as well.
However I can see an use case where overwriting the version in app.start() would make sense. And that is all that matter. I will change it to have this option too.
3.13.0 is out
IMO that doesn't matter. As stated above, this feature is primarily for testing old-version apps, so having one in example is no harm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change made.
Summary
This PR adds a method to create QuarkusCliRestService from existing sources. It should do similar job as already existing "createApplication" methods.
This feature is important for "quarkus update" testing. For testing advanced scenarios (such as updating entire app with business logic) we need to have prepared app, which we can then update and start. It is not feasible to construct entire app from scratch in tests.
Please check the relevant options
run tests
phrase in comment)Checklist: