Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in QuarkusCLIUtils #1236

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix issues in QuarkusCLIUtils #1236

merged 1 commit into from
Aug 5, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Aug 2, 2024 •
edited
Loading

Summary

Fix issues identified in #1235

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from jedla97 August 2, 2024 08:58
This was referenced Aug 2, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version'

jedla97
jedla97 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes, this look good to me!

@jedla97
Copy link
Member

jedla97 commented Aug 5, 2024

Flaky test is io.quarkus.qe.StrimziKafkaWithCustomSslMessagingIT.checkUserResourceByNormalUser

@jedla97 jedla97 merged commit a6f6c8e into quarkus-qe:main Aug 5, 2024
8 checks passed
@mocenas mocenas deleted the fix_cli_utils branch August 5, 2024 06:53
@mocenas mocenas mentioned this pull request Aug 14, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedla97 jedla97 jedla97 approved these changes

Assignees
No one assigned
Labels
triage/flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mocenas @jedla97