Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Manage fabric8 client version in framework #1250

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Aug 20, 2024

Summary

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

* Due to quarkusio/quarkus#42656, this
  implements a workaround where we manage fabric8 version ourselves
  rather than letting Quarkus manage it, as this leads to binary
  incompatible versions of library.
@mjurc mjurc requested a review from fedinskiy August 20, 2024 18:54
@mjurc mjurc self-assigned this Aug 20, 2024
@mjurc
Copy link
Member Author

mjurc commented Aug 20, 2024

run tests

@mjurc mjurc changed the title Manage fabric8 client version in framework [DRAFTManage fabric8 client version in framework Aug 20, 2024
@mjurc mjurc changed the title [DRAFTManage fabric8 client version in framework [DRAFT] Manage fabric8 client version in framework Aug 20, 2024
@mjurc
Copy link
Member Author

mjurc commented Aug 20, 2024

Alright, I'm drafting this, as the failures seem very related

@mjurc mjurc removed the request for review from fedinskiy August 21, 2024 22:30
@mjurc
Copy link
Member Author

mjurc commented Aug 21, 2024

Closing this as we went with building framework built on Quarkus snapshot version for the snapshot testing needs as a hotfix for now

@mjurc mjurc closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant